Skip to content

fix populateResourceFromAnnotation field setting#624

Merged
ack-prow[bot] merged 2 commits intoaws-controllers-k8s:mainfrom
michaelhtm:fix/populateresourceannotationset
Sep 20, 2025
Merged

fix populateResourceFromAnnotation field setting#624
ack-prow[bot] merged 2 commits intoaws-controllers-k8s:mainfrom
michaelhtm:fix/populateresourceannotationset

Conversation

@michaelhtm
Copy link
Member

@michaelhtm michaelhtm commented Sep 19, 2025

Description of changes:
Since we know the adoptionFields are always going to be map[string]string, we don't need to use
setResourceForScalar, which handles all types of scalar assignments.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and knottnt September 19, 2025 21:45
@ack-prow ack-prow bot added the approved label Sep 19, 2025
@michaelhtm michaelhtm mentioned this pull request Sep 19, 2025
Open
a-hilaly
a-hilaly previously approved these changes Sep 19, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@a-hilaly a-hilaly dismissed their stale review September 19, 2025 21:47

missing unit tests

a-hilaly
a-hilaly approved these changes Sep 19, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2025
@ack-prow
Copy link

ack-prow bot commented Sep 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michaelhtm
Copy link
Member Author

michaelhtm commented Sep 19, 2025

/retest

@ack-prow
Copy link

ack-prow bot commented Sep 19, 2025 •
edited
Loading

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 44fe1db link false /test verify-attribution
s3-olm-test 44fe1db link false /test s3-olm-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ack-prow ack-prow bot merged commit 5bf1e45 into aws-controllers-k8s:main Sep 20, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@jlbutler jlbutler Awaiting requested review from jlbutler

@knottnt knottnt Awaiting requested review from knottnt

Assignees

@a-hilaly a-hilaly

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelhtm @a-hilaly